Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ronn with ronn-ng #16862

Closed
wants to merge 1 commit into from

Conversation

fel1x-developer
Copy link

@fel1x-developer fel1x-developer commented Mar 9, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolves #16861. ronn had its last update in 2010. ronn-ng supports 2.7 to 3.3 (https://github.com/apjanke/ronn-ng/blob/8ab6acc5c08f464539817d209f878659b0c1adf6/doc-project/Developer-Guide.md?plain=1#L54)

Someone needs to test if this work as what we expect. If so, this a new version including this patch should be released ASAP (macOS 14.4 & Xcode CLT 15.3 is already out!)

@fel1x-developer
Copy link
Author

How can I solve this CI failure?

@apainintheneck
Copy link
Contributor

Thanks for looking into this.

Are we sure that ronn-ng is that alternative man page generator that we want to use here? @Bo98 I see that you self-assigned the original issue. Is this what you had in mind?

Also, we don't want to vendor dev dependencies like this. That's why the check is failing. For the man page gems, we specifically download them whenever brew generate-man-completions is run in the following snippet which installs the :man group of gems in the gemfile. That's why ronn is currently listed as both optional and not required.

group :man, optional: true do
gem "ronn", require: false
end

Homebrew.install_bundler_gems!(groups: ["man"])

@fel1x-developer
Copy link
Author

Are we sure that ronn-ng is that alternative man page generator that we want to use here? @Bo98 I see that you self-assigned the original issue. Is this what you had in mind?

ronn-ng has the cloest functionality to ronn, and this can serve as a temporary solution while @Bo98 is figuring out what's going on and bring up a better solution.

@dduugg
Copy link
Member

dduugg commented Mar 10, 2024

Thanks for your first contribution!

It looks like ronn-ng has nokogiri as a transitive dependency. However, I noticed a note in the Gemfile that nokogiri is a disallowed dependency. (Introduced in this PR, cc @samford)

@dduugg
Copy link
Member

dduugg commented Mar 10, 2024

You disregard my last message, I see @Bo98 noticed this issue too, and opened #16868 <3

@fel1x-developer
Copy link
Author

You disregard my last message, I see @Bo98 noticed this issue too, and opened #16868 <3

Thanks for info! Closing this PR. Followed by #16868

@fel1x-developer fel1x-developer deleted the ronn-ng branch March 10, 2024 06:05
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew tests fails wth Xcode 15.3 on Apple Silicon
3 participants